ci: use different tokens to update docs and go version #52
Conversation
zimeg
added
semver:patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 62.89% 62.90% +0.01%
==========================================
Files 210 210
Lines 22154 22154
==========================================
+ Hits 13934 13937 +3
+ Misses 7132 7131 -1
+ Partials 1088 1086 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice! 🎉 The |
|
Shoutouts also to @kkemple for ideas on this change 👾 |
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📝 A note on the hidden meaning of secret variables in action inputs follow-
| app-id: ${{ secrets.GH_APP_ID }} | ||
| private-key: ${{ secrets.GH_APP_PRIVATE_KEY }} |
There was a problem hiding this comment.
These tokens were for the kind @slack-cli-releaser[bot] of #5.
If these changes are alright I plan to delete these secrets to avoid future confusions 🫡
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ LGTM @zimeg!
📔 I like how you've chosen to post-fix the environment variables with _RELEASER and _DOCS to keep them separate. Is it documented somewhere what permissions each token needs?
🗑️ Once we confirm things are working, it's definitely a good idea to delete the unused secrets.
|
@mwbrooks Wonderful callouts and suggestion once more! I appreciate a second set of eyes on these changes so much 🙏 ✨
Interesting patterns appear with more variables! I tried other combinations but realized these got cluttered within the repo settings... I am also finding the "Build Docusaurus" step is successful with the updated secrets, so I will merge this PR. Then deleting secrets unused will be next. |
Summary
This PR uses different GitHub app tokens for updating upstream documentation and updating the
goversion.Fixes an issue where the prior token didn't have the right permissions to sync with docs. Or had the right permissions? 📚
Notes
MAINTAINERS_GUIDE.mdabout these apps? 🤔Requirements